fix: revert workaround for bug in nodejs 20.5 #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
commented
Sep 6, 2023
| const carCID = await Store.add( | ||
| { issuer: agent, with: space.did(), proofs, audience: serviceSigner }, | ||
| car, | ||
| { | ||
| connection, | ||
| onUploadProgress: (status) => { | ||
| assert(typeof status.loaded === 'number' && status.loaded > 0) | ||
| progressStatusCalls++ |
There was a problem hiding this comment.
On Nodejs 20.6 this is called more than once...
travis
approved these changes
Sep 6, 2023
vasco-santos
approved these changes
Sep 6, 2023
|
Oh I pressed merge button 🤦🏼♂️ @alanshaw let me know if I should revert |
|
No I want it merge |
alanshaw
pushed a commit
that referenced
this pull request
Sep 6, 2023
🤖 I have created a release *beep* *boop* --- ## [9.1.2](upload-client-v9.1.1...upload-client-v9.1.2) (2023-09-06) ### Bug Fixes * revert workaround for bug in nodejs 20.5 ([#905](#905)) ([a47ddd9](a47ddd9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the workaround for the bug in nodejs 20.5 (and below) which was resolved in nodejs 20.6.